Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved protocol to network module #2258

Open
wants to merge 1 commit into
base: v0.6
Choose a base branch
from
Open

Moved protocol to network module #2258

wants to merge 1 commit into from

Conversation

anand-skss
Copy link
Collaborator

  • Moved protocol to network module

@anand-skss anand-skss force-pushed the test5 branch 11 times, most recently from c5336d7 to ecf4f0e Compare June 27, 2024 02:31
@anand-skss anand-skss force-pushed the test5 branch 4 times, most recently from 8c8f0f3 to 3e71cc1 Compare July 4, 2024 02:25
@anand-skss anand-skss marked this pull request as ready for review July 4, 2024 02:46
PeterSurda
PeterSurda reviewed Jul 6, 2024
View reviewed changes
src/network/protocol.py
from helper_sql import sqlExecute
from network.node import Peer
from version import softwareVersion
try:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this isn't the best approach after all. Let's close it for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterSurda PeterSurda PeterSurda left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@anand-skss @PeterSurda